-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added globfilter command #1650
Added globfilter command #1650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, overall the code looks like how I would have implemented it myself.
I have left a few minor comments, if you could fix them that would be great.
Regarding the documentation, if you have Docker setup then you can just run Also please add Fixes #1649 to the PR description to link it properly, so it will close the corresponding issue when the PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes once again.
Marking this is as a breaking change since prior to this |
fixes: #1649, Added a new
globfilter
option which is verry similar toglobsearch
but only apply to thefilter
command.I only added documentation in
doc.md
because I think the rest of the files will be auto-generated on the next release (or the one after the next one)? Or should I rungen/doc-with-docker.sh
myself? Please let me know.